[Bug 207532] Review Request: kbackup - Back up your data in a simple, user friendly way

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kbackup - Back up your data in a simple, user friendly way


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207532





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-09-25 06:32 EST -------
First review of this package.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
  - rpmlint is not silent.
//usr/share/applications/kde/kbackup.desktop: error: required key "Encoding" not
found
E: kbackup invalid-desktopfile //usr/share/applications/kde/kbackup.desktop
   This is perhaps because kbackup.desktop doesn't have the entry of
   Encoding=UTF-8.

* Desktop files
  - Well, in GNOME I can see two desktop entries of KBackup under
  "system tools".  Perhaps either desktop file should have
  "OnlyShowIn=KDE;" entry and the other "OnlyShowIn=GNOME;"

* File and Directory Ownership
  The following directries are owned by other packages and
  should not be owned by this package.

/usr/share/applications/kde
/usr/share/icons/hicolor
/usr/share/icons/hicolor/16x16
/usr/share/icons/hicolor/16x16/apps
/usr/share/icons/hicolor/16x16/mimetypes
/usr/share/icons/hicolor/32x32
/usr/share/icons/hicolor/32x32/apps
/usr/share/icons/hicolor/32x32/mimetypes

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   = Nothing.

3. Other things I have noticed:
* I recommend that %configure is moved to %build stage.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.