[Bug 206266] Review Request: transmission - lightweight GTK+ BitTorrent client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: transmission - lightweight GTK+ BitTorrent client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206266





------- Additional Comments From denis at poolshark.org  2006-09-25 07:25 EST -------
Thanks for the review :-). Your points addressed below:

1. Fixed.

2. update-desktop-database calls fixed! The desktop-file-install looks good to
me. It doesn't have the --add-category Fedora option since the category is
already present in the desktop file (which is embedded into the spec). Many
packages embed the desktop file into the spec directly, while others check it
into CVS and add it as an extra Source: line. I'm not sure if one way is
preferred over the other...

3. The use of %makeinstall here is intentional. Transmission does not use
autoconf/automake and therefore does not honor DESTDIR, but rather uses a custom
makefile system. My understanding was that %makeinstall is targeted at cases
like this one, i.e. because it provides more variable definitions, more than
what is usually needed for autoconf/automake... ?

http://www.poolshark.org/src/transmission-0.6.1-2.src.rpm
http://www.poolshark.org/src/transmission.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.