[Bug 208004] Review Request: perl-Test-Perl-Critic - Use Perl::Critic in test programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Perl-Critic - Use Perl::Critic in test programs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208004


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-25 21:02 EST -------
* source files match upstream:
   91c1dc234b4c6ec1f06300085f0559cf  Test-Perl-Critic-0.07.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Test::Perl::Critic) = 0.07
   perl-Test-Perl-Critic = 0.07-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(English)
   perl(File::Spec)
   perl(Perl::Critic)
   perl(Perl::Critic::Utils)
   perl(Test::Builder)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=14,  3 wallclock secs ( 3.09 cusr +  0.39 csys =  3.48 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.