[Bug 187706] Review Request: alsa-oss - Userspace OSS emulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alsa-oss - Userspace OSS emulation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187706





------- Additional Comments From faucamp at csir.co.za  2006-09-27 05:59 EST -------
I'm not an official reviewer, but some review comments:

* source files match upstream:
6bb04b5ca6c6f7eed4827bd054a4ddeff6fb4e99  alsa-oss-1.0.11rc3.tar.bz2

* not newest version: 
ftp://ftp.alsa-project.org/pub/oss-lib/alsa-oss-1.0.12.tar.bz2

* spec file does not use macros consistently: $RPM_BUILD_ROOT, 
${RPM_BUILD_ROOT} and $RPM_OPT_FLAGS
(See 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf )

* -devel package has static libs and libtool archives specified in %files 
section (not packaged, though), see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

* dist tag is NOT present
* spec file named correctly
* build root is correct
* license field matches actual license, license is GPL, license text included 
in package
* BuildRequires are correct
* appropriate compiler flags present
* %clean is present
* package builds in mock (FC-5, i386)

* rpmlint: 
alsa-oss SRPM:
E: alsa-oss unknown-key GPG#f77eed90
W: alsa-oss mixed-use-of-spaces-and-tabs
alsa-oss RPM: no output
alsa-oss-devel RPM:
W: alsa-oss-devel summary-not-capitalized alsa-oss headers
W: alsa-oss-devel no-documentation

* package is not relocatable
* package installs properly
* documentation is small, no need for -doc subpackage
* %docs are not necessary for the proper functioning of the package
* scriptlets are good
* code, not content
* -devel Requires correct


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.