[Bug 208250] Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 28 11:46:19 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208250


aportal at univ-montp2.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alain.portal at free.fr




------- Additional Comments From aportal at univ-montp2.fr  2006-09-28 07:46 EST -------
(In reply to comment #1)
> Bad:
> 
> - Rpmlint of source package complaints:
> pmlint piklab-0.11.3-1.src.rpm
> E: piklab summary-too-long Development environment for applications based on 
PIC
> and dsPIC microcontrollers

I don't have this error with an uptodate rpmlint (0.78-1.fc5)

> E: piklab unknown-key GPG#8d4d7450

This is my key, please import.

> W: piklab strange-permission piklab-0.11.3.desktop.typo-fr.patch 0600
> W: piklab strange-permission piklab-0.11.3.x-desktop-fr.patch 0600
> W: piklab strange-permission piklab.spec 0600

OK.

> W: piklab mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 3)

It seems to me to not be really important.

> - rpmlint complains on binary rpm:
> E: piklab summary-too-long Development environment for applications based on 
PIC
> and dsPIC microcontrollers

ideem above

> W: piklab dangling-relative-symlink /usr/share/doc/HTML/en/piklab/common
> ../doc/common

I tried to get help about this warning, no real answer
https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00789.html

> /tmp/piklab-0.11.3-1.i686.rpm.18087/usr/share/applications/kde/piklab.desktop:
> warning: file contains key "DocPath", this key is currently reserved for use
> within KDE, and should in the future KDE releases be prefixed by "X-"

This is a KDE application.

> - Please use http://switch.dl.sourceforge.net/..., so spectool will work 
> properly.

prdownloads.sourceforge.net don't do the same?
what spectool?

> - Qt environment variable was not sourced.

Why sourcing Qt environment variables?

> - Duplicate BuildRequires: libart_lgpl-devel (by kdelibs-devel), fam-devel 
(by
> kdelibs-devel)

OK.

> - BuildRequires: gettext is missing (required to build the translations)

There is no translation in this package

> - Rpmlint complains on installed package:
> E: piklab summary-too-long Development environment for applications based on 
PIC
> and dsPIC microcontrollers
> W: piklab dangling-relative-symlink /usr/share/doc/HTML/en/piklab/common
> ../doc/common
> //usr/share/applications/kde/piklab.desktop: warning: file contains key
> "DocPath", this key is currently reserved for use within KDE, and should in 
the
> future KDE releases be prefixed by "X-"

Idem above


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list