[Bug 191745] Review Request: sysprof-kmod - kernel module for the sysprof profiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sysprof-kmod - kernel module for the sysprof profiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191745


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-09-30 02:10 EST -------
I think kernels above 2.6.16 do not require any smp kernels so either SPEC need
to  have some kversion checking or remove smp build lines.
Here is Review for your package which i built for 2.6.18 which do not have smp
support so i remove those lines form SPEC

Package Built successfully for i386 FC6 development
Rpmlint on SRPM
W: sysprof-kmod strange-permission kmodtool 0666
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.
=> This is well known rpmlint Warning on kmod packages. Forget it.

E: sysprof-kmod configure-without-libdir-spec
A configure script is run without specifying the libdir. configure
options must be augmented with something like --libdir=%{_libdir}.

I am not able to found any ./configure call in SPEC. Why this Error is coming 
Gianluca, any idea?


Rpmlint on RPM
W: kmod-sysprof summary-not-capitalized sysprof kernel module(s)
Summary doesn't begin with a capital letter.
=> This is well known rpmlint Warning on kmod packages. Forget it.

W: kmod-sysprof unstripped-binary-or-object
/lib/modules/2.6.18-1.2699.fc6/extra/sysprof/sysprof-module.ko
=> This is well known rpmlint Warning on kmod packages. Forget it.

W: kmod-sysprof no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.
=>Ignore this


Otherwise package looks ok.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.