[Bug 226138] Merge Review: metacity

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: metacity


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226138





------- Additional Comments From pertusus at free.fr  2007-04-04 03:41 EST -------
* a remark
the gettext_package, metacity_version and metacity_filename don't 
seem to be usefull to me, %{name}, %{version} and %{name}-%{version}
would seem more natural to me

* -I$RPM_BUILD_ROOT%{_includedir} seems wrong to me. Why is it there?
CPPFLAGS="$CPPFLAGS -I$RPM_BUILD_ROOT%{_includedir}"

* Why run autoreconf?

* on the make line, CPPFLAGS="$CPPFLAGS" LIBS="$LIBS" seems unuseful
to me, while %{?_smp_mflags} is missing (it worked in my tests)

* The pkgconfig Requires is unuseful in main package


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.