[Bug 234750] Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234750





------- Additional Comments From rc040203 at freenet.de  2007-04-04 10:30 EST -------
* MUSTFIX:
Useless man-pages
/usr/share/man/man1/avr-dlltool.1.gz
/usr/share/man/man1/avr-nlmconv.1.gz
/usr/share/man/man1/avr-windres.1.gz

These are Win tools, not being useful nor built for embedded avr-targets.
binutils installing them is a bug in binutils-2.17.*

* RECOMMENDATIONS:
- You are exporting CFLAGS:
export CFLAGS="$RPM_OPT_FLAGS"
./configure ...

This doesn't do any harm in this particular case (binutils is an ordinary,
native-only package), but will be harmful when a package applies
cross-compilation (e.g. when building GCC).

I recommend to pass CFLAGS on the configure command-line instead, i.e.
CFLAGS="$RPM_OPT_FLAGS" ./configure ...

This hard-codes CFLAGS into generated files and avoids conflicts between
different CFLAGS between Makefiles and environment.

- I'd recommend to build this package inside of an avr-binutils-... directory
instead of "binutils-..." (apply %setup magic)

- I'd recommend to build binutils "VPATH style" instead of "in-source-tree
style". Though this is not required by building binutils, it much less
error-prone than in-source-tree-builts (and required when building GCC)


In my specs I do all these steps this way:
%prep
%setup -q -c -T -n %{name}-%{version}
%setup -q -D -T -n %{name}-%{version} -a0

%build
mkdir -p build
cd build
CFLAGS="$RPM_OPT_FLAGS" ../binutils-%{version}/configure ....
cd ..

Finally: As you already know, I dislike a toolchains using an architecture (avr)
as their target, because this doesn't make much sense and actually is wrong if
wanting to be pedantic. But I don't want to insist on this, in this particular
case, because the avr always had been "special" and probably doesn't have a long
enough history (Other targets with a longer history have learnt their leasons:
i386-elf, m68k-elf, m68k-coff, arm-eabi)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.