[Bug 234436] Review Request: glchess - GlChess, a 3d Chess game using OpenGL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glchess - GlChess, a 3d Chess game using OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234436





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-04 12:54 EST -------
Created an attachment (id=151678)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151678&action=view)
mock build log of glchess-1.0.4-1 on FC-devel i386

Well, for 1.0.4-1:

* BuildRequires
  - mockbuild failed. At least desktop-file-utils is missing
    for BuildRequires.

* Executable permissions/shebang
--------------------------------------------
# make rpmlint happy
chmod +x $RPM_BUILD_ROOT%{python_sitelib}/%{name}/scene/opengl/png.py \
  $RPM_BUILD_ROOT%{python_sitelib}/%{name}/gtkui/__init__.py
--------------------------------------------
  - IMO the resolution should be opposite.

* GConf files
--------------------------------------------
%config(noreplace) %{_sysconfdir}/gconf/schemas/glchess.schemas
--------------------------------------------
  - Well, while I cannot find any wiki packages, however I am
    sure that GConf schemas files under /etc/gconf/schemas is
    generally _not_ regarded as config file and should not
    marked as %config (even if rpmlint complains about it).

* Some python related dependency
  - Well, would you check the following import sentence?
    * import Image (from opengl/texture.py: Perhaps python-imaging
      It seems that "Packages" link from http://glchess.sourceforge.net/
      requires it)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.