[Bug 235573] Review Request: websec - Web page monitoring software with highlighting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: websec - Web page monitoring software with highlighting


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235573





------- Additional Comments From fedora at leemhuis.info  2007-04-07 13:55 EST -------
Thanks for the review Ville.

(In reply to comment #1)
> - Even though the dep on smtpdaemon probably pulls in the needed thing, it
> sounds incorrect; websec just needs a sendmail executable, not a SMTP daemon ->
> change dependency to "MTA" or "/usr/sbin/sendmail"?

Changed (there are some packages in Fedora that seem to do it like this, but I'm
not sure if they need a daemon or just /usr/sbin/sendmail)

 
> - %define debug_package stuff + comment can be removed, this is a noarch package.

Note to myself: make noarch packages noarch first, before looking at the size of
the debuginfo package ;-)
 
> - s/mozilla/xdg-open/ in the example url.list?

Hmmm; I've thought about it a bit, but I think more people know what "mozilla"
is and does than what "xdg-open" does (which is not installed on any of my
Fedora machines...)

= Updated package = 

Spec URL:
http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/websec.spec

SRPM URL: 
http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/websec-1.9.0-2.src.rpm

DIFF URL: 
http://www.leemhuis.info/files/fedorarpms/DIFFS.fdr/websec.diff

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.