[Bug 235550] Review Request: mysql-gui-tools - Graphical Tools for mysql

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-gui-tools - Graphical Tools for mysql


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235550





------- Additional Comments From kevin at tummy.com  2007-04-07 15:54 EST -------
See below - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
063fda21a80f1b1a3e96231433b3f24b  mysql-gui-tools-5.0r11.tar.gz
063fda21a80f1b1a3e96231433b3f24b  mysql-gui-tools-5.0r11.tar.gz.1
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

See below - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
See below - Package owns all the directories it creates.
OK - No rpmlint output.
See below - final provides and requires are sane.

SHOULD Items:

See below - Should build in mock.
OK - Should build on all supported archs
See below - Should have subpackages require base package with fully versioned
depend.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Should address the naming (as mentioned above). I think 5.0r11-1.%{dist} might be
correct here. Is the next version likely 5.0r12? or ?

2. There are some packages that are included here within the source. Should try
and use the existing packages for them instead of using the bundled versions?

in mysql-query-browser there is a full copy of gtksourceview
(which is already available in fedora).

in mysql-gui-common/library/generic-runtime/ there is a full copy of 'newt'
(which is already available in fedora).

3. The Source url doesn't seem to work here. Looks like you might need to
pick one of the mirrors, ie:
http://dev.mysql.com/get/Downloads/MySQLGUITools/mysql-gui-tools-5.0r11.tar.gz/from/http://mysql.orst.edu/

4. Does there need to be a dependency on mysql? Or could this be installed/run
on a client machine with no mysql installed to talk to a server on another machine?
I guess it's linked to the client at least.

5. Will the java support work with the gcj setup in fedora?
If so, might be worth enabling.

6. Didn't build under mock here, I had to add:
BuildRequires: libgnomeprint22-devel
This looks to be in the gtksourceview build, so if thats removed it might not
be needed.

7. Do the other packages need anything from the -common package? Currently there are
no subpackage dependencies at all (ie, any of them could be installed alone) is
that correct? I would think the others would need to depend on -common at least
for directory ownership issues.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.