[Bug 225721] Merge Review: ekiga

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ekiga


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225721


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dakingun at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From dakingun at gmail.com  2007-04-14 13:03 EST -------
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Source, Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.
* Source matches upstream
md5sum: ec43c03ad942f87fb1d5cbcec5153b64  ekiga-2.0.7.tar.gz

NEEDSWORK:
* rpmlint have the following complaints
$ rpmlint ekiga-2.0.7-2.fc7.src.rpm
W: ekiga prereq-use scrollkeeper
W: ekiga unversioned-explicit-obsoletes gnomemeeting
W: ekiga macro-in-%changelog post
$ rpmlint ekiga-2.0.7-2.fc7.x86_64.rpm
W: ekiga incoherent-version-in-changelog 2.0.7-1 2.0.7-2.fc7
E: ekiga obsolete-not-provided gnomemeeting
W: ekiga non-conffile-in-etc /etc/gconf/schemas/ekiga.schemas
W: ekiga one-line-command-in-%postun scrollkeeper-update

There are also warnings as below in the build log;
Processing files: ekiga-2.0.7-2.fc7
warning: File listed twice: /usr/share/omf/ekiga/ekiga-C.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-bg.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-de.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-es.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-fr.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-pt_BR.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-sv.omf
warning: File listed twice: /usr/share/omf/ekiga/ekiga-uk.omf

It is sufficient to just have %{_datadir}/omf/ekiga without 
%{_datadir}/omf/ekiga/*.omf in the files manifest

BTW: There's a 2.0.9 release on the source ftp.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.