[Bug 236492] Review Request: ruby-bsearch - Binary search library for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-bsearch - Binary search library for Ruby


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236492





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-15 06:04 EST -------
(In reply to comment #1)
> Prereview as I'm still awaiting a sponsor:
> 
> [build at ip-50 SPECS]$ rpmbuild -ba ruby-bsearch.spec
> sh: ruby: command not found
> sh: ruby: command not found
> sh: ruby: command not found
> error: Failed build dependencies:
>         ruby is needed by ruby-bsearch-1.5-1.noarch
ruby is in BuildRequires.

(In reply to comment #2)
> From ReviewGuidelines:
> SHOULD: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.
Check bsearch.en.rd


> Also, according to bsearch.rb, it is licensed under ruby's license, which
> looking at /usr/share/doc/ruby-1.8.5.35/COPYING is GPL plus a custom one.  Might
> be better to reference as Ruby(GPL)?
I don't know the Ruby(GPL) license tag. ruby uses
"Ruby License/GPL", and actually this is a simple dual
license and referring to the license as GPL is not a
problem.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.