[Bug 236642] Review Request: Revisor - Revisor GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Revisor - Revisor GUI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236642


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jspaleta at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From jspaleta at gmail.com  2007-04-18 04:25 EST -------
Okay initial review comments.  Attached you will find an updated specfile which
fixes some simple problems in the specfile and the important rpmlint error
message concerning consolehelper symlink.
Fixes in updated specfile:

- remove makeinstall macro
- add usermode and pam requires
- make symlink to consolehelper relative path instead of absolute path
- removed desktop-update-database scriptlets and associated deps
  Refer to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

One thing I can't easily fix is the SOURCE0 tag.
Please refer to http://fedoraproject.org/wiki/Packaging/SourceURL
and follow the directions for Using Revision Control to add the appropriate
comment blog which gives the necessary instructions to rebuild the source
tarball locally. The goal is to provide the steps necessary for me to rebuild
the tarball so that I can do the appropriate md5sum check for the tarball you
have included.

Please regenerate a new spec and srpm with these corrections and I should be
able to run through the full formal review.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.