[Bug 237416] Review Request: Berusky - 2D logic game based on an ancient puzzle Sokoban.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Berusky - 2D logic game based on an ancient puzzle Sokoban.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237416


Jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |Jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From Jochen at herr-schmitt.de  2007-04-22 16:20 EST -------
Good:
+ Naming seems ok.
+ License seems ok.
+ Local build works ok.
+ Local install and unstall works fine.
+ Local start of the game works fine.
+ Package contains verbatin copy of the license.

Bad:
- Wrong build root
BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
- Missing SMP-Flags
Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
- Source contains not an full qualified URL.
- RPMlint complaints on binary package:
E: berusky zero-length /usr/share/doc/berusky/NEWS
E: berusky zero-length /usr/share/doc/berusky/ChangeLog
W: berusky incoherent-version-in-changelog 1.1-2 1.0-1
- Docs should be in %{_docdir}/%{name}-%{version}
- Mock build fails for berusky-1.0-1
make[2]: Leaving directory `/builddir/build/BUILD/berusky-1.0/po'
Making all in src
make[2]: Entering directory `/builddir/build/BUILD/berusky-1.0/src'
if g++ -DHAVE_CONFIG_H -I. -I. -I..    -Wall -g -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic -MT 2d_graph.o -MD -MP -MF ".deps/2d_graph.Tpo" -c -o
2d_graph.o 2d_graph.cpp; \
        then mv -f ".deps/2d_graph.Tpo" ".deps/2d_graph.Po"; else rm -f
".deps/2d_graph.Tpo"; exit 1; fi
if g++ -DHAVE_CONFIG_H -I. -I. -I..    -Wall -g -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic -MT animation.o -MD -MP -MF ".deps/animation.Tpo" -c -o
animation.o animation.cpp; \
        then mv -f ".deps/animation.Tpo" ".deps/animation.Po"; else rm -f
".deps/animation.Tpo"; exit 1; fi
In file included from animation.cpp:28:
berusky.h:48:18: error: zlib.h: No such file or directory
make[2]: *** [animation.o] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/berusky-1.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/berusky-1.0'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.57262 (%build)
I assume, that zlib-devel must be an BR in the source rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.