[Bug 216355] Review Request: vdr-skins - Collection of OSD skins for VDR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-skins - Collection of OSD skins for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216355


Axel.Thimm at ATrpms.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From Axel.Thimm at ATrpms.net  2007-04-22 17:02 EST -------
(In reply to comment #2)
> > o Some parts under /etc should probably move into /usr/share.
> 
> Makes sense, although only the *.theme files remain in /etc/vdr/themes and
> that dir can't be changed without changing it in the main vdr package as well. 
> Added to my TODO list for future vdr package revisions.

Maybe just a symlink in /etc pointing to a /usr/share location?

> I've had it in this package for ages, and IMHO upstream
> availablity/verification is not *that* critical because it's only data.
> If you feel more comfortable with dropping it for now, will do and
> reintroduce later if upstream reappears.

No, that's not a blocker, at least not for me, and I hope that the guidelines
can be interpreted as such.

Verification of sources is needed for novice errors and untrusted parties, I'd
say in this case we can outrule both. :)

I just wanted to mention these issues to keep them in mind, and to have this in
the review in case someone digs this up in the future and thinks we didn't do a
thorough job, after all I need to write something about whether the sources
could be verified or not.

I'd say, if you like move the non-config parts out of /etc leaving a symlink
behind, but that's just a mild recommendation. I'll just go ahead and approve as
is. :)

BTW: Perhaps you want to remove the %{?dist} tag, as the package wouldn't change
from release to release. But I don't know how to make the exact same package
appear in FC5/FC6/F7 simultaneously w/ either plague or brew, so maybe you can't
drop it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.