[Bug 227579] Review Request: spr - Statistical pattern recognition

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: spr - Statistical pattern recognition


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227579





------- Additional Comments From wart at kobold.org  2007-04-22 19:13 EST -------
(In reply to comment #4)
> For 05.01.00-1:
> 
> * rpmlint - attached
>   Summary:
>   - libSPR.so.0.0.0 contains undefined non-weak symbols.

Good catch.  I always forget to run rpmlint on the installed packages.

> * Timestamps

Fixed.

> * header files location
>   - Generally, if a package installs "many" header files, their
>     header files should be hidden in the package specific directory
>     to aboid namespace conflict.
>     Would you consider to move all header files to under
>     %{_includedir}/%{name}/ ?

Good idea.  I'll also suggest that upstream use this as a default.

New packages:

http://www.kobold.org/~wart/fedora/spr.spec
http://www.kobold.org/~wart/fedora/spr-05.01.00-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.