[Bug 236177] Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-NetAddr-IP - Manages IPv4 and IPv6 addresses and subnets
Alias: perl-NetAddr-IP

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236177





------- Additional Comments From cweyl at alumni.drew.edu  2007-04-26 11:41 EST -------
Oddly enough, the module itself is (as near as I can determine) definitely
under the Artistic license, though it includes a copy of the GPL at
Lite/Util/GPL.  Weird. --along the same lines, Makefile.PL complains if
Test::Pod isn't installed, but no test actually uses it.

The non-versioned requires on perl(NetAddr::IP::Util) would normally need to
be filtered, but as this package also provides perl(NetAddr::IP::Util), it's
really not worth the effort :)

Missing BR on Test::More -- approval is contingent on this being added (which
can be done post-import).

+ source files match upstream:
4f0ef938abf0b1e43ca96fb0068381df  NetAddr-IP-4.004.tar.gz
4f0ef938abf0b1e43ca96fb0068381df  ../NetAddr-IP-4.004.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  (Artistic) License text not included upstream.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
 ** perl-NetAddr-IP-4.004-0.2.fc6.x86_64.rpm
 == rpmlint
 == provides
 Util.so()(64bit)  
 perl(NetAddr::IP) = 4.4
 perl(NetAddr::IP::Lite) = 1.5
 perl(NetAddr::IP::Util) = 1.3
 perl(NetAddr::IP::UtilPP) = 1.2
 perl(NetAddr::IP::Util_IS) = 1.00
 perl-NetAddr-IP = 4.004-0.2.fc6
 == requires
 libc.so.6()(64bit)  
 libc.so.6(GLIBC_2.2.5)(64bit)  
 libc.so.6(GLIBC_2.3.4)(64bit)  
 libnsl.so.1()(64bit)  
 perl(:MODULE_COMPAT_5.8.8)  
 perl(AutoLoader)  
 perl(Carp)  
 perl(DynaLoader)  
 perl(Exporter)  
 perl(NetAddr::IP::Lite) >= 1.02
O perl(NetAddr::IP::Util)  
O perl(NetAddr::IP::Util) >= 0.17
 perl(NetAddr::IP::Util_IS)  
 perl(strict)  
 perl(vars)  
 ** perl-NetAddr-IP-debuginfo-4.004-0.2.fc6.x86_64.rpm
 == rpmlint
 == provides
 Util.so.debug()(64bit)  
 perl-NetAddr-IP-debuginfo = 4.004-0.2.fc6
 == requires
+ %check is present and all tests pass
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.