[Bug 231674] Review Request: libmimedir - Library to parse MIME Directory Profile

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmimedir - Library to parse MIME Directory Profile


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231674


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

andreas.bierfert at lowlatency.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From andreas.bierfert at lowlatency.de  2007-04-27 05:18 EST -------
* OK: rpmlint output: W: libmimedir-devel no-documentation can be ignored
 * NOTOK: E: libmimedir-debuginfo empty-debuginfo-package should probably be fixed
 * OK: package is named according to the guidelines
 * OK: spec file name matches base package name
 * OK: package meets packaging guidelines
 * OK: license
 * OK: license field matches actual license
 * OK: license is not included as own file and thus is not included in %doc
 * OK: Spec file seems to be in AE
 * OK: no obfuscated code spec
 * OK: sources match upstream:
156e1eb69377d9ae9180a09e38148ec6  libmimedir-0.4.tar.gz
156e1eb69377d9ae9180a09e38148ec6  /homes/awjb/rpmbuild/SOURCES/libmimedir-0.4.tar.gz
 * OK: Builds fine on x86_64/fc6
 * OK: BR seem fine
 * OK: package has no locale support
 * OK: package does not contain a shared library 
 * OK: package is not explicitly designed to be relocatable
 * OK: package does not create any directories
 * OK: no duplicate files in file listing
 * OK: %defattr and permissions seem ok
 * OK: %clean section is present
 * OK: macros are used consistently
 * OK: content is ok
 * OK: no doc package needed
 * OK: %doc files do not affect runtime
 * OK: header files are in -devel
 * OK: static lib in -static
 * OK: pkgconfig is not needed
 * OK: no .so file
 * OK: -devel requires main package
 * OK: package does not contain .la archives
 * OK: no .desktop needed
 * OK: does not own files/directories from other packages
 * OK: buildroot is rm at beginning of install
 * OK: filenames seem to be valid utf8

The debuginfo package is empty so either turn of the generation of the
debuginfo package or (better) fix the generation.

Other then that consider the package 8edf3312a0ab5b68bf670b50ed2b4f89 
libmimedir-0.4-2.src.rpm APPROVED with the following patch:

--- libmimedir.spec.1	2007-04-27 11:05:23.000000000 +0200
+++ libmimedir.spec	2007-04-27 10:58:24.000000000 +0200
@@ -34,32 +34,23 @@
 %build
 CFLAGS="$RPM_OPT_FLAGS -fPIC" %configure 
 make %{?_smp_mflags}
-# build shared libmimedir to work around x86_64 build error
-#ld --shared --whole-archive libmimedir.a -o libmimedir.so
-#rm libmimedir.a
 
 %install
 rm -rf $RPM_BUILD_ROOT
 mkdir -p $RPM_BUILD_ROOT/%{_libdir}
 mkdir -p $RPM_BUILD_ROOT/%{_includedir}
 install -m 644 libmimedir.h $RPM_BUILD_ROOT%{_includedir}
-install -m 444 libmimedir.a $RPM_BUILD_ROOT%{_libdir}
-#install -m 775 libmimedir.so $RPM_BUILD_ROOT/%{_libdir}/libmimedir.so
+install -m 644 libmimedir.a $RPM_BUILD_ROOT%{_libdir}
 
 rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
 
 %clean
 rm -rf $RPM_BUILD_ROOT
 
-%post -p /sbin/ldconfig
-
-%postun -p /sbin/ldconfig
-
 %files static
 %defattr(-,root,root,-)
 %doc README COPYING ChangeLog
 %{_libdir}/libmimedir.a
-#%{_libdir}/libmimedir.so
 
 %files devel
 %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.