[Bug 231679] Review Request: synce-serial - Serial connection support for Pocket PC devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: synce-serial - Serial connection support for Pocket PC devices


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231679


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

andreas.bierfert at lowlatency.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From andreas.bierfert at lowlatency.de  2007-04-27 05:44 EST -------
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 * OK: rpmlint W: synce-serial devel-file-in-non-devel-package
/usr/bin/synce-serial-config this is not a devel file so the warning can be ignored
 * OK: package is named according to the guidelines
 * OK: spec file name matches base package name
 * OK: package meets packaging guidelines
 * OK: license
 * OK: license field matches actual license
 * OK: license is not included as own file and thus is not included in %doc
 * OK: Spec file seems to be in AE
 * OK: no obfuscated code spec
 * OK: sources match upstream:
77f8879486469118386fb7429ec5a794  synce-serial-0.9.1.tar.gz
77f8879486469118386fb7429ec5a794 
/homes/awjb/rpmbuild/SOURCES/synce-serial-0.9.1.tar.gz
 * OK: Builds fine on x86_64/fc6
 * OK: BR seem fine
 * OK: package has no locale support
 * OK: ldconfig is not needed 
 * OK: package is not explicitly designed to be relocatable
 * OK: does not create own dirs
 * OK: no duplicate files in file listing
 * OK: %defattr and permissions seem ok
 * OK: %clean section is present
 * OK: macros are used consistently
 * OK: content is ok
 * OK: no doc package needed
 * OK: %doc files do not affect runtime
 * OK: no header files
 * OK: no static lib
 * OK: pkgconfig is not needed
 * OK: no .so file
 * OK: no devel package
 * OK: package does not contain .la archives
 * OK: no .desktop needed
 * OK: does not own files/directories from other packages
 * OK: buildroot is rm at beginning of install
 * OK: filenames seem to be valid utf8

Package 297b755c883c6d5d98cf69559796d02a  synce-serial-0.9.1-2.src.rpm
APPROVED with the following patch:

- --- synce-serial.spec.1	2007-04-27 11:42:27.000000000 +0200
+++ synce-serial.spec	2007-04-27 11:40:48.000000000 +0200
@@ -23,17 +23,14 @@
 
 Please read the included README.Fedora for details
 
- -
 %prep
 %setup -q
 cp -p %{SOURCE1} README.Fedora
 
- -
 %build
 %configure
 make %{?_smp_mflags}
 
- -
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
@@ -42,16 +39,9 @@
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d/
 echo 'ACTION=="add", SUBSYSTEM=="usb_device", SYSFS{idVendor}=="0bb4",
SYSFS{idProduct}=="0a06", SYMLINK+="ipaq", RUN+="%{_bindir}/synce-serial-start"'
> $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d/60-synce.rules
 
- -
 %clean
 rm -rf $RPM_BUILD_ROOT
 
- -
- -%post -p /sbin/ldconfig
- -
- -%postun -p /sbin/ldconfig
- -
- -
 %files
 %defattr(-,root,root,-)
 %doc README README.Fedora TODO LICENSE
@@ -60,8 +50,6 @@
 %{_mandir}/man8/synce-serial-*
 %config(noreplace) %{_sysconfdir}/udev/rules.d/*.rules
 
- -
- -
 %changelog
 * Mon Apr 02 2007 Aurelien Bompard <abompard at fedoraproject.org> 0.9.1-2
 - fix typo in description
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFGMcXCQEQyPsWM8csRAlQOAJ4hJdPfGNXuA3LSuAEMWBDwOJbrqACfWXpR
YxDkHbzmQFYlNn4ocjX2OWo=
=7QZc
-----END PGP SIGNATURE-----

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.