[Bug 234926] Review Request: ngircd - Next Generation IRC Daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ngircd - Next Generation IRC Daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234926





------- Additional Comments From dev at nigelj.com  2007-04-28 06:59 EST -------
(In reply to comment #12)
> Thanks, I'll change the patch accordingly.
> 
> About the tcp_wrappers requirement, the correct way of solving this is left up
> to the developer.
I agree, I was just suggesting one way.
> Adding a file-dependency is what I do not want to do.
I don't like file based dependencies myself to tell the truth.
> 
The reason why I suggested a file dependency for review only, is because once
reviewed, the spec file in FC6 can BR on tcp_wrappers and devel can BR on
tcp_wrappers-devel

Just for the sake of been complete with suggestions, the another appropriate way is:
As mentioned with the dependency altered to -devel, it can be built in RAWHIDE
obviously your using a FC-6 machine when creating packages (like myself), so
another method to settle the problem is to change the spec file with rawhide
compatible dependencies, and when testing on FC-6 use --nodeps.  Although not
specified in the PackageReviewGuidelines I'm pretty sure that most reviews agree
that packages must be buildable on the current devel at the very least.

The first solution I've provided will allow you build on both FC-6 and devel
while under review, the second will make the package only buildable on devel
during review, or with --nodeps on FC-6

As an after thought, depending on changes to the spec file, I know that it will
build on rawhide, and can approve a FC-6 compat spec file.


> I might either have a different specfile for the devel tree or I'd use
> conditionals like "%{fedora}" < "7" or something similar.
> I haven't decided yet, but I guess I'll go with the former.
I'd be happy to review a devel spec file, and a FC-6 spec file as another option

I've leave the choice up to you, but just remember, any workarounds for review
will be changed by the time it enters cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.