[Bug 244597] Review Request: rkward - Graphical frontend for R language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rkward - Graphical frontend for R language


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244597


cgoorah at yahoo.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |cgoorah at yahoo.com.au
               Flag|                            |fedora-review?




------- Additional Comments From cgoorah at yahoo.com.au  2007-08-07 16:36 EST -------
#001: License should NOW be GPLv2+
https://www.redhat.com/archives/fedora-devel-list/2007-August/msg00108.html

#002: missing %post and %postun:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda

%post
touch --no-create %{_datadir}/icons/locolor
touch --no-create %{_datadir}/icons/crystalsvg

%postun
touch --no-create %{_datadir}/icons/locolor
touch --no-create %{_datadir}/icons/crystalsvg

#003: rm -f ${RPM_BUILD_ROOT}%{_datadir}/apps/katepart/syntax/r.xml
${RPM_BUILD_ROOT} should be $RPM_BUILD_ROOT

#004: 
diff -Naur /var/tmp/rkward-0.4.7-2-root-chitlesh/usr/lib/R/library/R.css /usr/lib/R/library/R.css
see patch rkward-rcss.patch
I won't block this for approval.
But however, I would like that you file a bug against the package R stating 
that he/she should apply that patch! (added me as CC: please)
Reason: better integration :)

#005: remove the useless comment (though I won't block this for approval) :
#mkdir -p ${RPM_BUILD_ROOT}%{_libdir}/R

#006: you can remove CXXFLAGS="$RPM_OPT_FLAGS" from the spec file. As the 
optflags are already pulled out as shown below:
if 
g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/include/kde -I/usr/lib/qt-3.3/include -I.   -DQT_THREAD_SUPPORT  -D_REENTRANT -DQT_NO_ASCII_CAST  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common  -MT 
rkeditordataframe.o -MD -MP -MF ".deps/rkeditordataframe.Tpo" -c -o 
rkeditordataframe.o rkeditordataframe.cpp; \
        then mv -f ".deps/rkeditordataframe.Tpo" ".deps/rkeditordataframe.Po"; 
else rm -f ".deps/rkeditordataframe.Tpo"; exit 1; fi

#007: BuildRequires
remove :
*   R from the BR as R-devel already requires R
*   qt-devel from the BR as kdebase-devel requires kdelibs-devel and 
kdelibs-devel requires qt-devel

In the future you can use: 
rpm -qR R-devel
R = 2.5.1
[..]
to know whether R or any other package depends on it.

#008: %doc
missing TODO and AUTHORS in %doc

#009: rpath
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28rpath%29#head-7cea8c7aa96400a4687e843156354476434ff883
add
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' 
libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
after %configure even though you added --disable-rpath (I don't trust it :) )

I'm taking up the review.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.