[Bug 251190] Review Request: gds2pov - GDS2 layout file to POV-Ray conversion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gds2pov - GDS2 layout file to POV-Ray conversion


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251190





------- Additional Comments From pingoufc4 at yahoo.fr  2007-08-08 13:40 EST -------
MUST Items:

- MUST: rpmlint's output is clean except a warning about the absence of doc for
the devel package
I will not block approval for this

- MUST: The package is named according to the Package Naming Guidelines.
ok
- MUST: The spec file name matches the base package %{name}
ok
- MUST: The package meets the Packaging Guidelines.
ok
- MUST: The package is licensed (GPL) with an open-source compatible license 
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
ok
* MUST: The License field in the package spec file matches the actual license.
I have found only GPLv2 not GPLv2+ 
http://fedoraproject.org/wiki/Licensing

- MUST: the source package includes the text of the license(s) in its own 
file, then that file, containing the text of the license(s) for the package is
included in %doc.
ok
- MUST: The spec file must be written in American English.
ok
- MUST: The spec file for the package is be legible. 
ok
- MUST: The sources used to build the package must matches the upstream 
source, as provided in the spec URL.
ok
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
ok in FC6 i386
- MUST: All build dependencies is listed in BuildRequires.
ok
- MUST: The spec file handles locales properly.
ok
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
ok
- MUST: the package is not designed to be relocatable
ok
- MUST: the package owns all directories that it creates.
ok
- MUST: the package does not contain any duplicate files in the %files 
listing.
ok
- MUST: Permissions on files are set properly.
ok
- MUST: The package has a %clean section, which contains rm -rf %{buildroot} 
(or $RPM_BUILD_ROOT).
ok
- MUST: The package consistently uses macros, as described in the macros 
section of Packaging Guidelines.
ok
- MUST: The package contains code, or permissable content. This is described 
in detail in the code vs. content section of Packaging Guidelines.
ok
- MUST: There are no Large documentation files
ok
- MUST: %doc does not affect the runtime of the application. To summarize: If 
it is in %doc, the program must run properly if it is not present.
ok
- MUST: There are no Header files or static libraries 
ok
- MUST: The package does not contain library files with a suffix 
ok
- MUST: Package does NOT contain any .la libtool archives
ok
- MUST: Package containing GUI applications includes a %{name}.desktop file, 
and that file must be properly installed with desktop-file-install in 
the %install section.
ok
- MUST: Package does not own files or directories already owned by other 
packages. 
ok


SHOULD Items:

 - SHOULD: The source package does include license text(s) as COPYING
ok
 - SHOULD: mock builds succcessfully in i386.
ok
 - SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
ok
 - SHOULD: No subpackages present.
ok


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.