[Bug 248431] Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 10 01:56:55 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-FTPServer - Secure, extensible and configurable Perl FTP server
Alias: perl-Net-FTPServer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248431


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu
              Alias|                            |perl-Net-FTPServer




------- Additional Comments From cweyl at alumni.drew.edu  2007-08-09 21:56 EST -------
Excellent.  I'm going to need this package on a couple boxes of mine soon :)

(In reply to comment #2)
> I was debating adding BR /usr/bin/uudecode, but that would make more sense if I
> added a runtime dependency also, and I'm not sure I really want to encourage
> turning on that functionality in a FTP server.

Adding a BR will allow the test suite to fully exercise functional bits of the
module and would seem to be in order...
 
> The zip generation is optional functionality.  I'm not sure how important the
> test error is.  The build completed fine for me even with that error.
> 
> I can look into it a little deeper now if you want though.  (I planned on
> looking at that later anyway...)

Filing a bug upstream and noting it in the spec would probably be a good way to
address this sort of error in the test itself.  (Just from the message here, it
sounds like t/350generatorzip.t is probably mis-calling Archive::Zip.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list