[Bug 234326] Review Request: bandsaw - A syslog monitoring program for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bandsaw - A syslog monitoring program for the GNOME desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234326


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(splinux25 at gmail.co
                   |                            |m)




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-11 11:55 EST -------
David, if you want to do this style of (pre-)review, please also
write the summary of your (pre-)review, especially what you
think is the problem with this package so that everyone (not only
you and the submitter but also someone else) can check your review
easily...

>From very quick check of this package and your comment:
(In reply to comment #7)
> (In reply to comment #4)
> > new spec: http://glive.tuxfamily.org/fedora/bandsaw/bandsaw.spec

> > %post
> > update-desktop-database &> /dev/null ||:
> - I don't know if it makes a difference, but the snippet shows || :
  - You can check what "|| :" means by "man bash". This is to 
    ensure that %post stage will exit successfully even if the
    command failed with some reason.
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

> MUST Items:
> .x rpmlint result:
> W: bandsaw non-conffile-in-etc /etc/gconf/schemas/bandsaw.schemas
   - For GConf schemas file, this rpmlint can be removed.

> E: bandsaw no-binary
>   - Please use the output of rpmlint -i for more info to solve these.
   - This package seems to be noarch package so actually this must
     be fixed.

> %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
>   Can you point to an existing fedora spec that uses similar ?
   http://fedoraproject.org/wiki/Packaging/Python

> .x Packages containing GUI applications must include a %{name}.desktop file, and
> that file must be properly installed with desktop-file-install
> >+ desktop-file-install --vendor= --delete-original --dir
> /var/tmp/bandsaw-0.3.0-2.fc7-root-root/usr/share/applications
> /var/tmp/bandsaw-0.3.0-2.fc7-root-root//usr/share/applications/bandsaw.desktop
> /var/tmp/bandsaw-0.3.0-2.fc7-root-root/usr/share/applications/bandsaw.desktop:
> warning: The 'Application' category is not defined by the desktop entry
> specification.  Please use one of "AudioVideo", "Audio", "Video", "Development",
> "Education", "Game", "Graphics", "Network", "Office", "Settings", "System",
> "Utility" instead
>   - Application category is not defined in:
> http://standards.freedesktop.org/menu-spec/latest/apa.html. Please remove.
  - Please fix this, Damien

>   - this is a python/gtk/glade program. Is python bytecode crossplatform, ie
> will it just work on any platform ? If so should it be noarch ?
  - This is noarch.

(In reply to comment #8)

> When run as a user I see:
> $ bandsaw 
> Traceback (most recent call last):
>   File "/usr/bin/bandsaw", line 31, in <module>
>     import egg.trayicon
>   File "/usr/lib/python2.5/warnings.py", line 62, in warn
>     globals)
>   File "/usr/lib/python2.5/warnings.py", line 83, in warn_explicit
>     for item in filters:
> ImportError: could not import gtk
 - Lots of dependencies are missing. Approprate "Requires" should
   be added.

Setting to NEEDINFO as reply from the submitter is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.