[Bug 253043] Review Request: elftoaout - A utility for converting ELF binaries to a.out binaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elftoaout - A utility for converting ELF binaries to a.out binaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253043


jima at beer.tclug.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jima at beer.tclug.org
               Flag|                            |fedora-review+




------- Additional Comments From jima at beer.tclug.org  2007-08-16 15:42 EST -------
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
be3bd6f7ba8ae107cbdbaa820ba64f86  elftoaout-2.3.tgz
be3bd6f7ba8ae107cbdbaa820ba64f86  elftoaout-2.3.tgz.1
n/a - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

Requires:
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)

Provides:
elftoaout = 2.3-9.fc8


SHOULD Items:

OK - Should build in mock.
See below (#1) - Should build on all supported archs
See below (#2) - Should function as described.
OK - Should have dist tag
OK - Should package latest version
0 bugs - check for outstanding bugs on package.

Notes:
#1: Package is designed for SPARC.  Will it build anywhere else?  Is
there any practical use for it anywhere else?  I won't claim to know.
(However, will we need to file ExclusiveArch bugs?)

#2: As far as I can tell, it works.  It generates the exact same a.out
image as Aurora Corona's elftoaout.  (Not that that's terribly
conclusive...it's a good sign, though.)

I think we're probably good for now.  We might want to look at DaveM's
patch, which is dated 2006-01-03 as opposed to our 2002-06-03-ish patch
(and includes the same and then some), but I don't think it's dire.

I'm calling elftoaout APPROVED.  Pass Go, collect 200 bogomips.

It's amusing to note, by the way, that while this package doesn't have
any open bugs, it does have two closed ones: BZ#446 and BZ#9679.  No,
those numbers aren't typos. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.