[Bug 225667] Merge Review: cryptsetup-luks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cryptsetup-luks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225667


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
                 CC|                            |opensource at till.name
               Flag|needinfo?(pjones at redhat.com)|




------- Additional Comments From opensource at till.name  2007-08-17 08:34 EST -------
(In reply to comment #2)
> 1. Might have the devel subpackage
> Requires: %{name} = %{version}-%{release}
> instead of just
> Requires: %{name} = %{version}

committed in devel
 
> 2. Ditto the docs comments from comment #2.

commited in devel

> 3. rpmlint says:
> E: cryptsetup-luks statically-linked-binary /sbin/cryptsetup
> 
> Needs to be static per the bug mentioned in the changelog.

not anymore, it is build dynamically in devel

> E: cryptsetup-luks zero-length /usr/share/doc/cryptsetup-luks-1.0.3/NEWS
> E: cryptsetup-luks zero-length /usr/share/doc/cryptsetup-luks-1.0.3/README
> 
> Should be removed, per issue 2

commited in devel

> Can be ignored.
> 
> 4. 1.0.4 is out, perhaps upgrade to that?

Updated to 1.0.5 in devel
 
> 5. Should the static lib be shipped in the devel package here?
> Is there anything that uses it?

Static stuff has been removed in devel.

> 6. 8 outstanding bugs. Might look at those. I think at least one should
> be solved by upgrading to 1.0.4, possibly more.
 
done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.