[Bug 239936] Review Request: oyranos - The Oyranos Colour Management System (CMS)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oyranos - The Oyranos Colour Management System (CMS)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239936





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-19 09:54 EST -------
For -7:

* Again pc file
  - This time oyranos_monitor.pc has:
--------------------------------------------
Requires: x11 xinerama
--------------------------------------------
    This means that -devel package should have:
    "Requires: libX11-devel libXinerama-devel".

    However, are these Requires really needed?
    #include macro search returns:
--------------------------------------------
$ grep -h '#include ' `rpm -ql oyranos-devel | grep /usr/include` | sort | uniq
#include "oyranos.h"
#include "oyranos_definitions.h"
#include "oyranos_version.h"
#include <stdlib.h> /* for linux size_t */
--------------------------------------------
     and it does not seem to require those two -devel
     package.

* Documents
  - IMO all files "AUTHORS COPYING ChangeLog README" must be
    installed into -libs subpackage, because both main and -devel
    package require -libs subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.