[Bug 251680] Review Request: amtterm - Serial-over-lan (sol) client for Intel AMT

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amtterm - Serial-over-lan (sol) client for Intel AMT


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251680





------- Additional Comments From dlutter at redhat.com  2007-08-20 18:24 EST -------
Review (based on 0.4 srpm/spec):

OK - Naming, versioning, sources identical with upstream
OK - Package builds in rawhide/fc7/fc6 buildroot
OK - spec file is sane

FIX - License tag is ok, but there's no license text anywhere. At the least,
include an appropriate copy of the GPLv2 as %doc; even better if the source
files have a header that gives the license/copyright, too. (In general, we defer
to upstream on these issues, but since you are upstream, it would be good to fix
that)
FIX - rpmlint complains about missing 'rm -rf %{buildroot}' in %install
FIX - Source should point to full URL for downloading the source tarball, i.e.
http://dl.bytesex.org/releases/%{name}/%{name}-%{version}.tar.gz
FIX - Remove the 'Autoreqprov' line from the specfile; AFAIK, not needed for Fedora

Apart from these cosmetic fixes, looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.