[Bug 253649] Review Request: vinagre - VNC client for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vinagre - VNC client for the GNOME desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253649





------- Additional Comments From rstrode at redhat.com  2007-08-21 11:14 EST -------
When building in mock I get:


checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool

I've seen that problem before although I don't remember the details.  Is it that
the packaged intltool requires XML::Parser?  I'm guessing either BuildRequires
the parser or BuildRequires intltool and re-intltoolize will fix it.

Overall looks very good.  Minor nits that don't matter:

- rm -rf $RPM_BUILD_ROOT/%{_datadir}/doc/vinagre/  has an extra / in it (between
ROOT and %{_datadir}
- what docs are in the above anyway?  omf files? Are they worth shipping?
- vendor isn't required anymore for desktop-file-install, just ditch it.
- There are a handful or so Application categories, normally when tossing the
Application category, you pick one of them to replace it with (Maybe use Network?)
- you have %{_datadir}/%{name}/* in the file list but the package should
probably own the %{_datadir}/%{name} dir too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.