[Bug 254018] Review Request: rubygem-fastthread - optimized thread.rb replacement

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-fastthread - optimized thread.rb replacement


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254018


dlutter at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dlutter at redhat.com
               Flag|                            |fedora-review+




------- Additional Comments From dlutter at redhat.com  2007-08-23 20:47 EST -------
OK - Package name
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly
OK - Macro usage is consistent
OK - rpmlint output. rpmlint complains about missing docs, but that's an
upstream problem

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch specific content in %{gemdir}
OK - Defines ruby_sitearch from rbconfig
OK - arch specific content moved to %{ruby_sitearch}

BAD - License info isn't given explicitly, only inferred from the fact that
fastthread is part of mongrel and falls under mongrel licensing (not something
to fix for this review, but to point out to upstream at some point)

Package doesn't create a -debuginfo; but given the gyrations of building
rubygems, that can't be done sanely.

APPROVED

Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import
the package. Close this bug as RAWHIDE once it's been successfully imported
and built.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.