[Bug 251805] Review Request: postgresql-orafce - Implementation of some Oracle functions into PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-orafce - Implementation of some Oracle functions into PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251805





------- Additional Comments From kaigai at kaigai.gr.jp  2007-08-24 10:27 EST -------
Created an attachment (id=172420)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=172420&action=view)
postgresql-orafce build log

The following comments are based on the Package Review Guidelines and the
Packaging Guidelines. But I'm not a sponsor of the Fedora project, so these are
not official review comments.

- You should post the results of rpmlint command.

- You should apply the common compiler flags defined as $RPM_OPT_FLAGS or
%{optflags} .

- You should use -p option with 'install' command to preserve timestamps.

- You should improve Makefile to enable to build with non-privilleged user.
See the attachment. "make install" tries to make a directory of
"/usr/share/pgsql/contrib", and %buildroot is not used.
I could not build your package because of this problem.

- In addition, "/usr/share/pgsql/contrib" should be owned this package, if you
intend to create the directory actually. It is not owned by the postgresql
package.

[Package Review Guidelines]
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

[The Packaging Guidelines]
http://fedoraproject.org/wiki/Packaging/Guidelines)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.