[Bug 251824] Review Request: maniadrive - 3D stunt driving game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maniadrive - 3D stunt driving game


https://bugzilla.redhat.com/show_bug.cgi?id=251824





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-08-31 15:52 EST -------
(In reply to comment #4)
> 1. The following BRs were added in order to get it to compile:
> 
> zlib-devel
> curl-devel
> libxml2-devel
> 
> They might not be strictly needed though, if you see point 4.
> 

You're right, they aren't needed.

> 
> 2. The description for Raydium reads poorly and has several spelling mistakes.
> A suggested corrected version is below.
> 
> "Raydium is a game engine. It provides a set of functions which allow quick and
> flexible games creation. There are a lot of other 3D/game engines (and some
> are very complete, such as Ogre, Crystal Space, etc). Raydium does not try to
> be as complex as these engines, but on the contrary is aiming at quick and
> simple development."
> 

I've put in your version.

> 3. Is this file useful to the end user? If so, would it be better placed in the
> doc directory? It could give the rayphp location at the top for context. I'm not
> familiar enough with the software to say either way.
> 
> /usr/share/raydium/rayphp/README
> 

It doesn't contain any info usefull to the enduser.

> 4. Additional rpmlint warnings.
> 
> W: raydium undefined-non-weak-symbol /usr/lib/libraydium-1.2.so sapi_globals
> ...
> ...
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> libphp5-5.2.3.so

I think you used -force or -nodeps when installing, that cause these.

> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /usr/lib/libvorbis.so.0
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /usr/lib/libogg.so.0
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /lib/libresolv.so.2
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /lib/libcrypt.so.1
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/lib/libz.so.1
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /usr/lib/libcurl.so.4
> W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
> /usr/lib/libxml2.so.2
> 

The others are fixed now.

> 5. I read a packaging doc on the wiki that recommended against using macros in
> patch names, but of course I can't find it now. :)
> 

You shouldn't use %{version}, as you may want to apply the same patch to a newer
version, %{name} is no problem.

> 6. I think raydium-devel may need dependencies on
> freealut-devel
> libvorbis-devel

Good catch, it also needs glew, libjpeg and ode -devel.

Here is a new version with the following changes:
* Fri Aug 31 2007 Hans de Goede <j.w.r.degoede at hhs.nl> 1.2-2
- Improved and spell-fixed raydium description
- Fix a number of unused direct shlib dependencies in libraydium-1.2.so
- Add Requires on various -devel packages to the raydium-devel subpackage so
  that all headers included by the raydium headers will be present

Spec URL: http://people.atrpms.net/~hdegoede/maniadrive.spec
SRPM URL: http://people.atrpms.net/~hdegoede/maniadrive-1.2-2.fc8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.