[Bug 400441] Review Request: trac-iniadmin-plugin - Expose all TracIni options using the Trac 0.10 config option API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trac-iniadmin-plugin - Expose all TracIni options using the Trac 0.10 config option API


https://bugzilla.redhat.com/show_bug.cgi?id=400441


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide




------- Additional Comments From tibbs at math.uh.edu  2007-11-30 22:15 EST -------
You might want to reference SVN revision in the comment after URL; referencing
"latest" gets a different file which happens to have the same contents (for now).

Should the version be "0.1" or "0.10"?  setup.py says one thing, but the tarball
would seem to suggest otherwise.  I'm going to assume that 0.1 is proper and the
0.10 refers to the trac version it works with.

Does this package really need python-setuptools at runtime?

rpmlint says:
  trac-iniadmin-plugin.noarch: W: no-documentation
which is OK; it really has no documentation.

Checklist:
* source files match upstream:
   f915159e70818d74a0a46e4803e8dce09249001dded58d476d60825982f90310  
   iniadminplugin_0.10-r2824.zip
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has acceptable complaints.
? final provides and requires:
   trac-iniadmin-plugin = 0.1-1.20071126svn2824.fc9
  =
   python(abi) = 2.5
?  python-setuptools
   trac
  Is python-setuptools really required?

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* eggs are built from source.
* no dependencies are downloaded.  (Not that it would work in mock anyway.)
* egg-info files are included in the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.