[Bug 241078] Review Request: perl-Net-SSH2 - Support for the SSH 2 protocol via libSSH2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-SSH2 - Support for the SSH 2 protocol via libSSH2
Alias: perl-Net-SSH2

https://bugzilla.redhat.com/show_bug.cgi?id=241078


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-30 23:32 EST -------
Not much to say; now builds fine in rawhide because libssh2 is there, and
rpmlint is silent.

* source files match upstream:
   4bd78eb0b3099271e2047d4e727c8105c07d22d732ca0fb76c37b11f80b64fc4  
   Net-SSH2-0.18.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   SSH2.so()(64bit)
   perl(Net::SSH2) = 0.18
   perl(Net::SSH2::Channel)
   perl(Net::SSH2::Dir)
   perl(Net::SSH2::File)
   perl(Net::SSH2::Listener)
   perl(Net::SSH2::PublicKey)
   perl(Net::SSH2::SFTP)
   perl-Net-SSH2 = 0.18-1.fc9
  =
   libssh2.so.1()(64bit)
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.8.8)
   perl(AutoLoader)
   perl(Carp)
   perl(Exporter)
   perl(File::Basename)
   perl(IO::File)
   perl(Net::SSH2::Channel)
   perl(Net::SSH2::File)
   perl(Net::SSH2::Listener)
   perl(Net::SSH2::SFTP)
   perl(Socket)
   perl(XSLoader)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   61/72 skipped: - non-interactive session
   All tests successful, 61 subtests skipped.
   Files=1, Tests=72,  0 wallclock secs ( 0.04 cusr +  0.02 csys =  0.06 CPU)
  (Skipped tests are not runnable within mock)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.