[Bug 352761] Review Request: ds9 - Astronomical Data Visualization Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ds9 - Astronomical Data Visualization Application


https://bugzilla.redhat.com/show_bug.cgi?id=352761





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-01 04:15 EST -------
Well, for 5.0-2:

* Version specific dependency
----------------------------------------------------------
[tasaka1 at dhcp158 ~]$ ds9
Error in startup script: couldn't read file
"/usr/share/tcl8.4/tcllib-1.9/base64/base64.tcl": no such file or directory
    while executing
"source /usr/share/tcl8.4/tcllib-1.9/base64/base64.tcl"
    invoked from within
"if {![catch {package present checkdns}]} {
    set ds9(root) "/usr/share/ds9"

    source /usr/share/tcl8.4/msgcat1.3/msgcat.tcl
    source /usr/share..."
    (file "/usr/share/ds9/src/ds9.tcl" line 65)
----------------------------------------------------------
   - Now rawhide tcllib is tcllib-1.10-1.fc9.
     * At least a patch against src/ds9.tcl seems needed
     * It is better that the dependency against tcllib is
       version specific, i.e. "Requires: tcllib = 1.9"
       so that like this time we can know that ds9 has to
       be rebuilt when tcllib is upgraded.
     * Or you have some better solution?

* Scriptlets
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
  - The installed desktop files contains MimeType key and
    desktop database must be updated.

* The location of icon
  - "sun.gif" seems rather generic name and IMO it is better
    that this icon is moved under %_datadir/pixmaps/%name
    (desktop file modification is needed).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.