[Bug 398581] Review Request: 8Kingdoms - 8 Kingdoms is a 3D turn-based fantasy strategic game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: 8Kingdoms - 8 Kingdoms is a 3D turn-based fantasy strategic game


https://bugzilla.redhat.com/show_bug.cgi?id=398581


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide




------- Additional Comments From wart at kobold.org  2007-12-01 20:19 EST -------
GOOD
====
* rpmlint output contains UTF-8 warnings as noted above.  This is ok
  since the HTML files contain the proper encoding header.
* Source matches upstream, with the exception of the missing extgl.h
  as noted in the spec file 
* GPL+ license ok, since only a COPYING files is included and source
  files don't appear to have any copyright statements in them.
* License file included
* spec file name ok
* spec file legible and in Am. English
* No locale handling needed
* No shared libaries
* Package is not relocatable
* Owns all directories that it creates
* No duplicate %files 
* buildroot cleaned where appropriate
* file permissions ok
* No headers, static libraries, pkgconfig files, or -devel subpackage
* .desktop file installed correctly.

MUSTFIX
=======
* Does not compile on F8-x86_64.  Must replace 'BuildRequires: expat'
  with 'BuildRequires: expat-devel'


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.