[Bug 399721] Review Request: fusion icon - Compiz Fusion panel applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fusion icon - Compiz Fusion panel applet


https://bugzilla.redhat.com/show_bug.cgi?id=399721


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-03 11:44 EST -------
no problem for now but take care to remove them from next release please.
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint complains follwing messages on RPMS
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/data.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/interface.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/start.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/parser.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/execute.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/environment.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/__init__.py 0644
fusion-icon.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/util.py 0644
fusion-icon-gtk.noarch: W: no-documentation
fusion-icon-gtk.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/main.py 0644
fusion-icon-gtk.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/__init__.py 0644
fusion-icon-qt.noarch: W: no-documentation
fusion-icon-qt.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/main.py 0644
fusion-icon-qt.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/__init__.py 0644
+ source files match upstream with assumptions that logs will differ
dd4c1c967fe4bb1282801e22bb43fa41  fusion-icon-20071126.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists but -gtk and -qt subpackages present.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.