[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netdump-server - netdump crash recovery capture server


https://bugzilla.redhat.com/show_bug.cgi?id=378791





------- Additional Comments From nhorman at redhat.com  2007-12-03 13:11 EST -------
ok, new version available:
Spec URL: http://people.redhat.com/nhorman/rpms/netdump-server.spec
SRPM URL: http://people.redhat.com/nhorman/rpms/netdump-server-0.7.16-18.fc8.src.rpm

>netdump-server.x86_64: W: incoherent-version-in-changelog -0.7.16-17
Fixed


>Looking more closely at your scriptlets, I see that you're restarting the
service in %post while the recommended scriptlets at...

I think the %post condrestart is vestigual.  I've added an identical %postun
scriptles to be compliant.  I'll remove the %post script at a later date, when I
can confirm that its no longer needed.

>The Summary: is a little confusing
Fixed

>I don't see anything in the package which indicates that indicates the GPL
version
See COPYING in the docs.  Its included in the srpm

>Looking at the build process, I see that the compiler isn't being called with
the proper set of flags
Fixed

>I note that /var/crash is owned in rawhide by kexec-tools
I've moved this package to write to /var/netdump/.  We need to allow this
package and kexec-tools to co-exist.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.