[Bug 254008] Review Request: objectweb-asm - Version 3.0 of the ObjectWeb ASM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: objectweb-asm - Version 3.0 of the ObjectWeb ASM


https://bugzilla.redhat.com/show_bug.cgi?id=254008





------- Additional Comments From loganjerry at gmail.com  2007-12-03 13:15 EST -------
For [2], did you notice that rpmlint complains about README.txt?  When I open
the files with a hex editor, I see 0x0d 0x0a sequences in both of them.

As for [3], xml-commons-apis is Required by ant as you note, so when you
BuildRequire ant, it gets pulled in.  Then the rpm scripts add everything in
/usr/share/java to your CLASSPATH, so it is magically available.  Try building
without ant; i.e., explicitly invoke javac on all of the source files.  You'll
see that the compile fails with a message about being unable to resolve a bunch
of imports that all start with org.xml.sax.

It is my understanding that every build requirement, even those that are
satisfied transitively, must be listed in the BuildRequires unless they appear
on the exceptions list:

http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions

So even though the BuildRequires of ant pulls it in, it should be listed anyway,
in case some future version of ant stops Requiring it.

The classes in src/org/objectweb/asm/xml call methods provided by
xml-commons-apis / jaxp, so for asm-xml.jar to be useable, xml-commons-apis must
be installed at runtime, hence the Requires.  It isn't using reflection, nor is
it something optional.  That jar will do nothing but throw
ClassNotFoundExceptions if xml-commons-apis is not installed.  The other jars
don't need it, so this is possibly a candidate for a subpackage.

See the reference to JAXP here:
http://asm.objectweb.org/current/doc/javadoc/user/org/objectweb/asm/xml/package-summary.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.