[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netdump-server - netdump crash recovery capture server


https://bugzilla.redhat.com/show_bug.cgi?id=378791





------- Additional Comments From tibbs at math.uh.edu  2007-12-04 01:27 EST -------
OK, your move to /var/netdump has elicited the following from rpmlint:
  netdump-server.x86_64: W: non-standard-dir-in-var netdump
which I don't suppose is problematic.  Personally I'd think /var/lib/netdump
would be better, but if /var/crash is there and this stores the same data then I
don't see why it shouldn't be in the same place.

The %postun scriptlet looks proper but there's certainly no reason to restart
the service twice on upgrade.  Currently you're doing a condrestart of the
service in %post at install time ($1 == 1) and at upgrade time ($1 == 2), and
then at upgrade time in %postun.  Honestly, I can't see what the point of that
is; just restart it in %postun like any other service and be done with it.

At this point I think the package is fine save for two issues:

License: tag.  Please try to determine whether this is GPLv2 or GPLv2+ (or
something else) and then set the License: tag appropriately.  Judging from the
only statement anywhere in the package (in comments at the start of
netdump-server.8) I'd say GPLv2+ is proper.

Scriptlets.  Please just remove the condrestart call from %post.  I really can't
envision a reason for the way it is now.  Or, if you'd rather not, we can get a
third party to comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.