[Bug 320421] Review Request: cwrite - console editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwrite - console editor


https://bugzilla.redhat.com/show_bug.cgi?id=320421





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-04 11:26 EST -------
For 0.1.13-1:

* setuid/gid
  - Ah, you wrote "+s" Then:
    * You must not change the permission on %post. Instread
      you must specify the permission at %files section like:
-------------------------------------------------------
%files
%attr(4755,root,root) %{_bindir}/%{name}
-------------------------------------------------------
    * And if you want to use setuid, perhaps I have to ask
      RH security responsible team about this as we now consider 
      that using setuid/gid is generally dangerous. Is this
      "really" needed?

* License
  - Still the tag "GPL" is invalid.
    ! Note
      The COPYING file is GPLv3, however apart from this 
      file there are no files in the tarball which limits
      the version of GPL applied to only 3.
      Then we regard the license of this software as
      "GPL+" (i.e. "any version" of GPL) due to the section
      14 "Revised Versions of this License"

      Currently the license tag for this spec file is "GPL+".

* BuildRequires
  - Is autoconf needed for BuildRequires?

* %doc
  - Generally The file "INSTALL" 
      is for people who want to build and install the software 
      by themselves and is not needed for people who use rpm to 
      install the software.

* Requires(post,postun): /sbin/install-info
  - Why is this needed? This file does not contain any info
    files and actually post/postun scriptlets don't use install-info.
  - Also is "rm -f %{buildroot}%{_infodir}/dir" in %install
    really needed?

* Empty %preun
  - Please remove this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.