[Bug 407571] Review Request: tinyxml - A simple, small, C++ XML parser

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 4 18:14:01 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tinyxml - A simple, small, C++ XML parser


https://bugzilla.redhat.com/show_bug.cgi?id=407571





------- Additional Comments From pertusus at free.fr  2007-12-04 13:14 EST -------
The tinyxml.h timestamp isn't kept, one way to achieve that would be
to do something like

%patch0 -p1 -b .stl
touch -r tinyxml.h.stl tinyxml.h

Otherwise on multilib installs rpm -V will show spurious differences.


If I recall well, it is advised to use $RPM_OPT_FLAGS during linking
(for the arch -m* options), maybe you could consider doing that?


Also in general the library name contains the version, like
g++ -shared -o lib%{name}.so.%{version} -Wl,-soname,lib%{name}.so.0 *.cpp.o
And then you can use ldconfig to do the first link, like
install -m 755 lib%{name}.so.%{version} $RPM_BUILD_ROOT%{_libdir}
/sbin/ldconfig -n $RPM_BUILD_ROOT%{_libdir}/
ln -s lib%{name}.so.0 $RPM_BUILD_ROOT%{_libdir}/lib%{name}.so


I don't have any other comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list