[Bug 411491] Review Request: perl-MRO-Compat - Mro::* interface compatibility for Perls < 5.9.5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-MRO-Compat - Mro::* interface compatibility for Perls < 5.9.5
Alias: perl-MRO-Compat

https://bugzilla.redhat.com/show_bug.cgi?id=411491


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-12-05 06:55 EST -------
make test gave me
t/01use.............ok
t/02pod.............skipped
        all skipped: Test::Pod 1.14 required for testing POD
t/03pod_coverage....skipped
        all skipped: Test::Pod::Coverage 1.04 required for testing POD coverage
t/10basic...........ok
t/15pkg_gen.........ok
t/20mros............ok
All tests successful, 2 tests skipped.

AND
rpmlint gave
perl-MRO-Compat.src:47: W: rpm-buildroot-usage %build rm -rf %{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:49: W: rpm-buildroot-usage %build make pure_install
PERL_INSTALL_ROOT=%{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:51: W: rpm-buildroot-usage %build find %{buildroot} -type f
-name .packlist -exec rm -f {} +
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:52: W: rpm-buildroot-usage %build find %{buildroot} -depth
-type d -exec rmdir {} 2>/dev/null \;
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:54: W: rpm-buildroot-usage %build %{_fixperms} %{buildroot}/*
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

perl-MRO-Compat.src: W: no-%install-section
The spec file does not contain an %install section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality.  Add the
section, even if empty.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.