[Bug 411881] Package review: sim

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: sim


https://bugzilla.redhat.com/show_bug.cgi?id=411881


mmahut at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(mmaslano at redhat.co
                   |                            |m)




------- Additional Comments From mmahut at redhat.com  2007-12-05 08:46 EST -------
Hi Marcela,

+ Package is named according to the Package Naming Guidelines.
+ Spec file name must match the base package %{name}, in the format %{name}.spec.
+ Package meets the Packaging Guidelines.
+ Package successfully compiles and builds into binary rpms on at least one
supported architecture. 
+ Rpmline output is sane.
+ Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
+ Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
License field in the package spec file matches the actual license. (GPLv2+)
+ Sources used to build the package matches the upstream source, as provided in
the spec URL. (4bc30577e619e05252d394d51dc20747)
+ Package must own all directories that it creates.
+ Package does not contain duplicates in %files.
+ Permissions on files are set properly.
+ Package has a %clean section, which contains rm -rf %{buildroot}
+ Latest version is packaged.


- Package does not compile in mock.
  You forgot to include autoconf and automake as BuildRequires, but also flex.

  w/o autotools: 
http://koji.fedoraproject.org/koji/getfile?taskID=275886&name=build.log
  w/ autoools:   
http://koji.fedoraproject.org/koji/getfile?taskID=275917&name=build.log

Please fix these issues and let me know.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.