[Bug 226467] Merge Review: system-config-rootpassword

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-rootpassword


https://bugzilla.redhat.com/show_bug.cgi?id=226467





------- Additional Comments From panemade at gmail.com  2007-12-06 07:02 EST -------
You should remove %attr(0644,root,root) in %files section

mock build gave me
/var/tmp/system-config-rootpassword-1.99.2-1.fc9-root-mockbuild/usr/share/applications/fedora-system-config-rootpassword.desktop:
error: value "system-config-rootpassword.png" for key "Icon" in group "Desktop
Entry" is an icon name with an extension, but there should be no extension as
described in the Icon Theme Specification if the value is not an absolute path
Error on file
"/var/tmp/system-config-rootpassword-1.99.2-1.fc9-root-mockbuild/usr/share/applications/system-config-rootpassword.desktop":
Failed to validate the created desktop file


If we fix above then build.log showed me
warning: File listed twice: /usr/share/system-config-rootpassword/pixmaps

rpmlint reported
system-config-rootpassword.noarch: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-rootpassword
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here

system-config-rootpassword.src:22: W: unversioned-explicit-obsoletes
redhat-config-rootpassword
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.