[Bug 412001] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ufoai - UFO: Alien Invasion strategy game


https://bugzilla.redhat.com/show_bug.cgi?id=412001





------- Additional Comments From kvolny at redhat.com  2007-12-06 09:17 EST -------
(In reply to comment #6)
> No, but if upstream distributes separate tarbals (and they do) you must make
> seperate srpms.

well, this should be written in the guidelines ...

> Then when someone fixes an engine bug, all users will thank you
> for not having to redownload the data files again, which is what would
> happen on a yum update if all were in the same spec, as you cannot rebuild
> only certain sub-packages, when rebuilding all get rebuild, and the all get
> a higher EVR, so even though the data isn't changed a yum update will still
> download it.

somehow I thought that I can specify different release for the subpackages, 
but thinking about it, its nonsense ... thanks for the explanation

> If its really playable without accel then thats ok. The wrapper is there for
> cases where software rendering goes so slow the mouse becomes very jumpy and
> even navigating to the quit entry of the menu becomes hard.

well, the latter is true on most machines that I tried, so no doubt the 
wrapper should be added


so here we go:
http://www.hajnet.cz/soubory/ufoai.spec
http://www.hajnet.cz/soubory/ufoai-2.1.1-2.fc8.src.rpm
http://www.hajnet.cz/soubory/ufoai-data.spec
http://www.hajnet.cz/soubory/ufoai-data-2.1.1-1.fc8.src.rpm
http://www.hajnet.cz/soubory/ufoai-music.spec
http://www.hajnet.cz/soubory/ufoai-music-2.1.1-1.fc8.src.rpm

a few outstanding issues:

- I've noticed that the license file for music states that the author does not 
wish it to be used in other projects, but no separate licensing is mentioned 
on the project page or anywhere else so that the same as the whole project, 
GPLv2+, should be used, imho ... or should I consult 
fedora-legal-list at redhat.com? (I'm not a member)

- I do not understand why "dash-EOF" syntax does not work as expected within 
the wrapper generation ... not a big deal, though :-)

- rpmlint complains about missing %build for the data and music packages ... 
is that mandatory to have this section even if empty?

- afaik, rpm does not support optional dependencies, how to suggest 
installation of ufoai-music together with ufoai without depending on it hard?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.