[Bug 226142] Merge Review: mikmod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mikmod


https://bugzilla.redhat.com/show_bug.cgi?id=226142


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From bugs.michael at gmx.net  2007-12-06 15:33 EST -------
> Summary: A MOD music file player

Summary: Music module player

That is because "MOD" is a synonym for the .mod file format of
SoundTracker (and simple derivatives), but not for the more
recent and advanced file formats, such as those mentioned in
the %description. Those are much more commonly called "modules".

> %description

s/MOD music file/music module/g


> Release: 5%{?dist}

Could you please squeeze the "beta1" in there (even if it's too
late to prefix with "0.")? For example:

Release: 6.beta1%{?dist}


> $ rpmlint  /tmp/mikmod-3.2.2-5.fc9.src.rpm 
> mikmod.src:30: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT

That command belongs at the beginning of %install, not %build.


Especially the last item must be fixed. The other ones are minor.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.