[Bug 411421] Review Request: d-feet - D-Bus debugger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: d-feet - D-Bus debugger


https://bugzilla.redhat.com/show_bug.cgi?id=411421


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-06 22:03 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is NOT silent for SRPM. But silent for RPM.
d-feet.src: E: description-line-too-long D-Bus is an RPC library used on the
Desktop.  D-Feet can be used to inspect D-Bus objects of running programs and
invoke methods on those objects.
+ source files match upstream url
35f713feee9b9b8a7ec5fff6d2fd18fa  d-feet-0.1.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper(with extra unnecessary scrollkeeper)
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ gtk-update-icon-cache scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.
+ GUI App.
APPROVED.

SHOULD:
  fix rpmlint and BR problem.
  According to
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
  If upstream uses <vendor_id>, leave it intact, otherwise use fedora as
<vendor_id>.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.