[Bug 275081] Review Request: xenwatch - Virtualization utilities, mostly for Xen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xenwatch - Virtualization utilities, mostly for Xen


https://bugzilla.redhat.com/show_bug.cgi?id=275081


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-06 23:13 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
c0ff0bc66945f2e664ca6a7afb7b67e5  xenwatch-0.5.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct thought good to use as defattr(-,root,root,-)
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop files installed correctly.
+ Package xenwatch-0.5.2-2.fc9 ->
  Provides: config(xenwatch) = 0.5.2-2.fc9
  Requires: config(xenwatch) = 0.5.2-2.fc9 libX11.so.6 libXext.so.6
libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2
libdl.so.2 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0
libgmodule-2.0.so.0 libgnutls.so.13 libgobject-2.0.so.0 libgtk-vnc-1.0.so.0
libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libvirt.so.0
libxenstore.so.3.0 libxml2.so.2 rtld(GNU_HASH) screen
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.